LatestValueCache: Expose keys for which messages have been received #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
the
part:tests
There was a problem hiding this comment.
Pull Request Overview
This PR adds a keys() method to LatestValueCache to expose the set of keys for which messages have been received and includes integration tests verifying its behavior.
- Introduces
keys()onLatestValueCachewith a docstring and return type. - Adds assertions in integration tests to validate
keys()before and after messages arrive.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_latest_value_cache_integration.py | Added assert cache.keys() == ... checks around message sends and error cases |
| src/frequenz/channels/_latest_value_cache.py | Imported Set and implemented keys() returning the internal keys view |
Comments suppressed due to low confidence (1)
src/frequenz/channels/_latest_value_cache.py:154
- The method is annotated to return a
Setbut returns adict_keysview; consider converting to a built-inset(e.g.,return set(self._latest_value_by_key.keys())) to match the annotation or update the return type to reflect the actual view type.
return self._latest_value_by_key.keys()
llucax
approved these changes
Jun 6, 2025
shsms
added
the
cmd:skip-release-notes
|
No release notes because this is an enhancement to an unreleased feature. |
Merged
via the queue into
frequenz-floss:v1.x.x
with commit Jun 6, 2025
6f24b25
5 of 6 checks passed
shsms
added a commit
to shsms/frequenz-channels-python
that referenced
this pull request
Jun 16, 2025
…ceived (frequenz-floss#425)" This reverts commit 6f24b25, reversing changes made to 3edcb49.
shsms
added a commit
to shsms/frequenz-channels-python
that referenced
this pull request
Jun 16, 2025
…ceived (frequenz-floss#425)" This reverts commit 6f24b25, reversing changes made to 3edcb49. Signed-off-by: Sahas Subramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.